Harmonic shift in McLachlan only works for conformalMethod = 1 (W method)

Create issue
Issue #1289 closed
Ian Hinder created an issue

The harmonic shift implemented in #591 is missing the case discrimination for the conformalMethod parameter; the way it is currently coded is correct for conformalMethod = 1 (W method) but not for conformalMethod = 0 (phi method). My original version of the code had the two variants but I removed this at some point while testing and my submitted patch contained only conformalMethod = 1. In my original notes, I have this

alpha^2 em4phi (gtu[ua, 
     uk] (PD[alpha, lk]/alpha + 
      2 IfThen[conformalMethod, -1/(2 phi), 1] PD[phi, lk]) - 
   gtu[ua, ul] gtu[uj, um] PD[gt[ll, lm], lj])

which should be checked again before committing.

Keyword: McLachlan

Comments (3)

  1. Ian Hinder reporter
    • changed status to resolved
    • removed comment

    Bernard Kelly has provided a patch (attached to #591) which includes the harmonic shift equation for conformalMethod = 0. I have tested that this yields the correct convergence to the exact solution for the 3D shifted gauge wave. Committed in McLachlan:

    http://git.carpetcode.org/McLachlan.git/commit/976593d219b2e0785540b1168cd58cffb0e3c76d
    http://git.carpetcode.org/McLachlan.git/commit/24fb409969654f964c10ac15894a8791680a6895
    
  2. Log in to comment