Cactus produces way too much output with SILENT!=no

Create issue
Issue #131 closed
Frank Löffler created an issue

I frequently find me scrolling through a lot of not necessary output from Cactus, including a lot of divider lines (___). I propose a mechanism to disable most of that output. There is currently one parameter which influences the amount of output from Cactus. If SILENT is set to 'no', Cactus provides way more output. All other values produce the usual output (including not setting it). I propose to use this existing variable to make Cactus less verbose if SILENT ist set to 'yes'. The default is 'undefined', so this would preserve the default Cactus behaviour.

The attached patch attempts to do this: it suppresses divider lines, pre- and postprocessing infos if SILENT='yes'. I don't like that name though, as this is still not really silent, as you will still see one line per compiled file (ala COMPILING /home/frank.loeffler/mcrt/src/main/Banner.c), but I don't have a better idea right now and could live with it. The other option would be to introduce another variable (e.g. BRIEF), but then BRIEF and SILENT could contradict each other.

Keyword:

Comments (11)

  1. Erik Schnetter
    • removed comment

    Yes, this is a good idea. This goes well with our current efforts to suppress unnecessary warnings from compiler output.

    Instead of SILENT=undefined, I would call it SILENT=default.

  2. Frank Löffler reporter
    • removed comment

    I didn't call it 'undefined'. This is the state the variable is in if it is not set: it is not defined, so it neither matches "yes", nor "no".

  3. Ian Hinder
    • removed comment

    I like this patch. Note that you need to reconfigure the configuration after applying this patch (make <configname>-reconfig) otherwise you still get some of the old messages. Instead of coming up with a different flag or a new meaning for the "SILENT" option, why not just make the new behaviour the default? I can't see any benefit in keeping the old behaviour.

  4. Ian Hinder
    • removed comment

    This ticket was under discussion on the developers mailing list:

    http://cactuscode.org/pipermail/developers/2011-January/006144.html

    The final word was:

    On 26 Jan 2011, at 20:14, Frank Loeffler wrote:

    On Wed, Jan 26, 2011 at 04:20:33PM +0100, Ian Hinder wrote: I only see the need for two levels:

    1. The new output format which just lists the filenames being compiled, and is much more compact than the current format; 2. Full output of the commands being executed, useful for debugging build problems.

    Currently that is all I would need. I could imagine that someone would like to have a completely silent build, for some reason. On the other hand, you could have that with a shell redirect quite easily, so I now also vote for just two levels, VERBOSE=[no]/yes.

    Frank

    <<

    I propose that the patch be modified to implement this.

  5. Log in to comment