- changed status to open
- removed comment
New thorn MemSpeed
I have written a thorn MemSpeed, available at https://svn.einsteintoolkit.org/incoming/MemSpeed. This thorn is useful for performance tuning. I propose to add it to CactusUtils.
From the README:
Determine the speed of the CPU, as well as latencies and bandwidths of caches and main memory. These provides ideal, but real-world values against which the performance of other routines can be compared.
Keyword:
Comments (8)
-
reporter -
reporter - changed status to resolved
- removed comment
Committed.
-
reporter - changed status to open
- removed comment
This thorn is in the repository, but not part of the EinsteinToolkit. I propose to add it to the Einstein Toolkit.
-
reporter - changed status to open
- removed comment
-
- changed status to open
- removed comment
This seems like a useful thorn to have available. Some comments:
- The name "MemSpeed" seems to be historical; the thorn measures both CPU and memory speeds. Maybe "HWSpeed" or "HWPerf" might be better? If it is to be renamed, now seems like a good time, before it is in the official thornlist. (optional)
- There is extensive documentation (thanks!)
- There is a test case. Am I correct that this test is safe to run as part of the automated tests? It says to skip the large memory benchmark. Does that mean it should be fast enough to run?
- I have skimmed through the code and didn't notice any major issues
I support inclusion in the toolkit as long as the default test case does not require large amounts of time or memory.
-
reporter - removed comment
-
The majority of the tests are for memory performance; the other tests are just small add-ons.
-
Yes, the test case should be safe to run. You can run multiple tests simultaneously on the same node. In fact, if the test case takes a long time to run, then this indicates a problem (e.g. wrong OpenMP configuration). The standard test (without disabling the large- memory test) can only run once simultaneously per node, and is useful only on compute nodes of clusters.
-
reporter - changed status to resolved
- removed comment
Added to manifest.th via https://bitbucket.org/einsteintoolkit/manifest/commits/8303c31adbb992a2b8945e79baea731bc7ac58f0
-
- edited description
- changed status to closed
- Log in to comment