simfactory does not return "nice" error message when local rsync version cannot be determined

Create issue
Issue #1394 closed
Roland Haas created an issue

currently, when the version of the local rsync executable cannot be determined (eg because the user has no executable privileges or because the regular expression did not match) the user is left with a python backtrace into lib/ stating that NoneType has no attribute groups.

The attached patch checks if the regular expression matched and if not reports a fatal error including rsync's return text in the error message.


Comments (4)

  1. Roland Haas reporter
    • changed status to resolved
    • removed comment

    applied as rev 2121 of simfactory.

    I left the (superfluous) "else" in so that the code logic matches what is done in GetCactusFile (purely aesthetic).

  2. Log in to comment