- removed comment
CarpetLib 2dedcb0e7340b0682d530dc26e764408b301e3b8 "CarpetLib: Do not reallocate communication buffers; instead, keep them around" breaks QLM qlm-bl.par test
Issue #1424
closed
With the commit in a up-to-date (trunk) Cactus tree the test (and others) fails with:
Without (reverting it on top of it 7671fa71925aebfd787497bae61cf6da6ddeac54 "CarpetIOHDF5: support IO->alias option in reader") succeeds. I attach the test log. parfile, thorn list and option list.
Keyword:
Comments (6)
-
reporter -
- changed status to open
- removed comment
Can you try this patch?
$ git diff diff --git a/Carpet/CarpetLib/src/commstate.cc b/Carpet/CarpetLib/src/commstate. index 5e9eb91..532461d 100644 --- a/Carpet/CarpetLib/src/commstate.cc +++ b/Carpet/CarpetLib/src/commstate.cc @@ -531,6 +531,11 @@ comm_state::~comm_state () { DECLARE_CCTK_PARAMETERS; + // Note: calling resize(0) instead of clear() ensures that the + // vector capacity does not change + srequests.resize(0); + rrequests.resize(0); + for (size_t type=0; type<typebufs.size(); ++type) { typebufdesc& typebuf = typebufs.AT(type); for (size_t proc=0; proc<typebuf.procbufs.size(); ++proc) {
-
- removed comment
I was having this same error. This patch fixes it. Thanks. Seth
-
- changed status to resolved
- removed comment
Applied.
-
reporter - removed comment
This patch fixes the issue for me. Thank you.
-
reporter - edited description
- changed status to closed
- Log in to comment
Error message is: