include 'thornlists' in sync-parfiles

Create issue
Issue #1491 closed
Frank Löffler created an issue

It would make sense to include the directory 'thornlists' into the sync-parfiles option in Simfactory. 'thornlists' is often created by GetComponents, and the thornlist is copied there.

Keyword:

Comments (8)

  1. Erik Schnetter
    • removed comment

    It makes sense in the sense that "thornlists" is a small directory as well.

    On the other hand, "parfiles" is needed for running simulations, whereas "thornlists" is only needed when building, and when building, one needs the source tree anyway. That means, when running a simulation one can safely just sync "parfiles" since this will copy all information required for running, whereas only copying "thornlists" before building may miss updated source files.

  2. Frank Löffler reporter
    • removed comment

    Maybe I misunderstand the meaning of 'sync-parfiles'. The use-case I have in mind is that I have my source on a development machine and now sync to a remote machine. Then I want to build there, and for that I need the thornlist. Thus, I have to sync it to the remote place as well. Currently this is not happening.

  3. Erik Schnetter
    • removed comment

    Oh. They should be synced by default.

    sync-parfiles is supposed to only sync parfiles. For building, you would use a plain "sync", and this should sync everything. If thornlists are not included, they need to be added.

  4. Frank Löffler reporter
    • removed comment

    That means adding it to 'sync-sources', I guess (see patch). Ok to apply?

  5. Log in to comment