ExternalLibraries do not check if patch is available

Create issue
Issue #1509 closed
Roland Haas created an issue

some of the ExternalLibraries (LORENE, hwloc for example) use patch to modify the upstream source. However they do not check if patch is available and blindly use the flesh supplied $PATCH variable.

Since the flesh does not abort its configuration even when patch is missing, this fails with an error message of the form "-p0: command not found".

Either the flesh's configure should require patch to be present, or the ExternalLibraries need to test for PATCH being empty (there is a bash expansion that aborts if PATCH is undefined).

Keyword: LORENE
Keyword: hwloc
Keyword: ExternalLibraries

Comments (6)

  1. Roland Haas reporter
    • changed status to open
    • removed comment

    The ExternalLibraries already all use the ${PATCH?} variant. The attached patches add more explicit checks and error messages.

    Please only review the .2 files. The first version contains a typo in the error message.

  2. Roland Haas reporter
    • changed status to resolved
    • removed comment

    Applied as rev 44 of BLAS rev 35 of FFTW3 rev 45 of GSL rev 84 of HDF5 rev 46 of LAPACK rev 50 or LORENE rev 41 of MPI.

  3. Roland Haas reporter
    • removed comment

    Also applied as rev 59 of OpenSSL rev 43 of hwloc rev 40 of libjpeg rev 41 of zlib.

  4. Log in to comment