Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData

Create issue
Issue #1617 closed
Steven R. Brandt created an issue

Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData, otherwise there's a risk of seg fault in Accelerator_NotifyDataModified due to a missing accelerator data structure. MoL fails to do this in Operators.c. Patch attached.

Keyword:

Comments (4)

  1. Erik Schnetter
    • removed comment

    Moving the initialization of is_device outside the if block is not necessary. It is also dangerous, because it will not have its correct value there.

    The first hunk of interface.ccl does not correspond to the current version in svn; in fact, it seems to correct a severe syntax error. Are you sure you started your diff against the current tree? Are you using "svn diff"?

  2. Roland Haas
    • removed comment

    Is the actual fix in there (calling Accelerator_RequireInvalidData) still required?

  3. Log in to comment