- removed comment
Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData
Issue #1617
closed
Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData, otherwise there's a risk of seg fault in Accelerator_NotifyDataModified due to a missing accelerator data structure. MoL fails to do this in Operators.c. Patch attached.
Keyword:
Comments (4)
-
-
- removed comment
Is the actual fix in there (calling
Accelerator_RequireInvalidData
) still required? -
reporter - changed status to resolved
- removed comment
Seems not to be a problem any longer.
-
- edited description
- changed status to closed
- Log in to comment
Moving the initialization of is_device outside the if block is not necessary. It is also dangerous, because it will not have its correct value there.
The first hunk of interface.ccl does not correspond to the current version in svn; in fact, it seems to correct a severe syntax error. Are you sure you started your diff against the current tree? Are you using "svn diff"?