- changed status to open
- removed comment
remove MOLDOESCOMPLEX from MoL
Issue #1624
closed
MOLDOESCOMPLEX is an old #define in MoL, and seems to be unused for quite some time now. It also comes with the comment "even using it probably doesn't work" in the commit. I suggest to remove it (removing the code within).
Keyword:
Comments (9)
-
reporter -
- changed status to open
- removed comment
Yes, this should be removed.
In the long term, all linear operations should be performed via MoL_LinearCombination. This routine should be extended to support complex variables as well.
-
- removed comment
Actually, this is already implemented in MoL_LinearCombination.
-
reporter - changed status to open
- removed comment
-
reporter - changed status to open
- removed comment
Please someone review the quite extensive deletions. It is a lot, but it should be fast (a lot of repetition).
-
- removed comment
Do the ET tests pass when this change is made?
-
reporter - removed comment
I only tested on my machine, and there they do.
-
reporter - changed status to resolved
- removed comment
Merged
-
- changed status to closed
- edited description
- Log in to comment