- changed status to open
- removed comment
GRHydro should not depend on ADMMacros
Issue #1642
closed
At the moment GRHydro uses ADMMacros::spatial_order to decide about how to calculate the source terms. ADMMacros is deprecated. There should be another mechanism to do this, and the dependence should be removed. Note that even the C++ code uses this parameter.
The simplest solution would probably be a GRHydro parameter, and this is what I suggest (sources_spatial_order).
Keyword: postrelease
Comments (8)
-
reporter -
- changed status to open
- removed comment
As discussed in the phone call today: no objections to making it a GRHydro parameter. It really seems to be only used in Source.F90 to decide which derivative to compute.
-
reporter - removed milestone
- removed comment
-
- changed status to open
- assigned issue to
- removed comment
There was nothing to review here.
-
reporter - changed status to open
- removed comment
Now there is. :)
-
- changed status to open
- removed comment
Patch looks fine. Please apply.
-
reporter - changed status to resolved
- removed comment
-
- edited description
- changed status to closed
- Log in to comment