Tests using ADMConstraints should be converted to use ML_ADMConstraints

Create issue
Issue #1711 open
Ian Hinder created an issue

In May 2014, ADMConstraints was removed from the ET thornlist. However, we have many tests which use this thorn, and they now cannot run. These tests were not just designed to test this thorn, they test other functionality as well. Looking at the test log file from Jenkins, I see the following tests which are skipped solely due to ADMConstraints being missing:

      (AEIThorns/ADMMass/test/tov.par)
      (AEIThorns/ADMMass/test/tov_carpet.par)
      (CactusNumerical/Cartoon2D/test/schw-0050.par)
      (CactusNumerical/Cartoon2D/test/test_cartoon_2.par)
      (CactusNumerical/Cartoon2D/test/test_cartoon_3.par)
      (EinsteinExact/EinsteinExact_Test/test/KS-tilted-EE.par)
      (EinsteinInitialData/Exact/test/de_Sitter.par)
      (EinsteinEvolve/GRHydro/test/test_one_hybrid.par)
      (CactusNumerical/RotatingSymmetry180/test/Kerr-EE.par)
      (CactusNumerical/RotatingSymmetry180/test/Kerr-rotating-180-EE.par)
      (CactusNumerical/RotatingSymmetry180/test/Kerr-rotating-180-staggered-EE.par)
      (CactusNumerical/RotatingSymmetry180/test/Kerr-staggered-EE.par)
      (CactusNumerical/RotatingSymmetry90/test/Kerr-rotating-90-EE.par)
      (CactusNumerical/RotatingSymmetry90/test/Kerr-rotating-90-staggered-EE.par)
      (EinsteinInitialData/TOVSolver/test/test_one_boost_max.par)
      (EinsteinInitialData/TOVSolver/test/test_one_static_max.par)
      (EinsteinInitialData/TOVSolver/test/test_two_av.par)
      (EinsteinInitialData/TOVSolver/test/test_two_max.par)
      (EinsteinInitialData/TwoPunctures/test/twopunctures.par)
      (EinsteinAnalysis/WeylScal4/test/teukolsky.par)
      (EinsteinAnalysis/WeylScal4/test/teukolskyID.par)
      (EinsteinAnalysis/WeylScal4/test/teukolskyParity.par)

I have removed ADMConstraints from the WeylScal4 tests, as it wasn't being used there, but the other tests probably do make use of it, and need to be ported to ML_ADMConstraints. We should add an item to the list of "things to do when deprecating a thorn", so that we fix the tests using that thorn before removing it.

Keyword:

Comments (1)

  1. Log in to comment