- changed status to open
- marked as
- removed comment
Avoid build-time warning
Issue #1713
resolved
I see this warning when building. I assume this should instead be a run-time warning or error?
/Users/eschnett/Cbeta/arrangements/EinsteinEvolve/GRHydro_InitData/src/GRHydro_PoloidalMagFieldM.F90:110:2: warning: #warning "This algorithm does only work on Cartesian grids!!" [-Wcpp]
#warning "This algorithm does only work on Cartesian grids!!"
^
Keyword:
Comments (8)
-
-
I have a beautiful patch for this but the comment field is too small to write it down.
I’ll make a pull request after the release.
-
- edited description
-
assigned issue to
-
Pull request is here: https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/19
-
Please review
-
@Erik Schnetter would you like to review the pull request that addresses the issue you reported?
Unless objected I will apply this after 2023-03-30
-
Applied as git hash a9b65e5 "GRHydro_InitData: check for curvilinear grid at runtime" of einsteinevolve
-
- changed status to resolved
Thank you @Erik Schnetter
- Log in to comment
If the results are always wrong, it should be a fatal error. If it is something that should be implemented, there could be a comment in the code and a ticket created.