use OPENSSL_DIR variable instead of SSL_DR

Create issue
Issue #1859 closed
Roland Haas created an issue

This is pull request

https://bitbucket.org/simfactory/simfactory2/pull-requests/2/use-openssl_dir-rather-than-ssl_dir/diff

for simfactory. The ExternalLibrary only looks at OPENSSL_DIR and not SSL_DIR. Currently the simfactory files only contain comments commenting on the fact that SSL_DIR will likely be ignored. Since we know it will be ignored it seems better to use the correct OPENSSL_DIR variable.

Keyword:

Comments (7)

  1. Frank Löffler
    • removed comment

    I'd rather see SSL_DIR used instead. SSL is what is provided, and OpenSSL only one possible implementation. We should have OPENSSL_DIR also recognized probably, with lower priority than SSL_DIR.

  2. Erik Schnetter
    • removed comment

    The library is called "OpenSSL". There is no generic "SSL" library, comparable e.g. to a "LAPACK". Alternative libraries have different names, e.g. "mbedTLS", with different APIs.

    We also always use configuration variable names that have the thorn name as prefix.

  3. anonymous
    • changed status to open
    • removed comment

    Well does this mean "please apply"? In that case would someone (other than me) please set the state to "reviewed"?

  4. Frank Löffler
    • changed status to open
    • removed comment

    At that moment it didn't mean 'approved', since that was only about the variable name. Now it is. :)

  5. Log in to comment