- changed status to open
- removed comment
correct finding normalization value for relerr compuation
Issue #1889
open
Before it would have taken the larger of the abs value of the new and old data of the last data set rather than the largest abs value of the new and old data of all the datasets.
This will make relative errros smaller and will be particularly noticeable in cases where the last dataset was small or zero.
This should get rid of the "Error, how did I get here" warnings (that really indicated an logic error).
Keyword:
Comments (4)
-
reporter -
reporter - changed status to open
- removed comment
I am no longer sure if this is the right fix. Instead it may be better to compute maxrelerr differently (directly when comparing instead of after the fact).
-
reporter -
reporter - removed comment
This is conceivably related to http://lists.einsteintoolkit.org/pipermail/users/2018-August/006462.html
- Log in to comment