- changed status to open
- removed comment
remove CACHELINE_BYTES and CACHE_SIZE from flesh
Nothing in Cactus uses these variables, and in some cases they are best guesses only. Also, as of 2fb3e32532bbe70121559d582d96b3c300c95276 (Erik Schnetter, Thu Jan 15 12:57:04 2015 -0500), Cactus (the flesh) lost it's ability to overwrite these variables via parameters. Thus, this is a little clean-up within the flesh.
Pull request: https://bitbucket.org/cactuscode/cactus/pull-requests/25/remove-cacheline_bytes-and-cache_size-from/diff
Keyword:
Comments (4)
-
reporter -
- changed status to open
- removed comment
Fine to apply, please also remove CACHELINE_BYTES related code from simfactory (seems to be in lib/sim-build.py when grep'ing for CACHELINE_BYTES). Consider creating a ticket to remove the corresponding option from simfactory and instead realy on hwloc (or similar) library to query this information at runtime.
-
reporter - changed status to resolved
- removed comment
-
- changed status to closed
- edited description
- Log in to comment