GRHydro_InitData -> HydroBase_InitData?

Create issue
Issue #1930 new
Zach Etienne created an issue

GRHydro_InitData seems to clash with the modern ET approach of making initial data thorns link only to HydroBase/ADMBase (i.e., being evolution-code agnostic), so that any evolution code may take advantage of the functionality.

With slight modifications (possibly requiring the creation of a simple GRHydro compatibility layer thorn, a la "ID_converter_ILGRMHD"), this thorn could be made useful to all HydroBase-compatible GRMHD codes.

Keyword:

Comments (1)

  1. Roland Haas
    • removed comment
    If you would like to propose changes to remove its tight binding to GRHydro (or separate those out) that would be very useful. The ID-only thorn could be named {{{Hydro_InitData}}} to remove its connection to {{{GRHydro}}}
    
  2. Log in to comment