CarpetLib's defs.hh and defs.cc file don't encapsulate defintions in a namespace

Create issue
Issue #2034 new
Roland Haas created an issue

CarpetLib's defs.hh and defs.cc do not (as far as I can tell) contain any namespace enclosing the defined functions so that they all end up in the global namespace eg its ipow and also its get_poison_value function. It should however either put them into a CarpetLib namespace or prefix them by CarpetLib_ like other symbols with global linkage.

This apparently has always been the case at least far back as importing carpet-5 into git (5 years ago).

Keyword:

Comments (0)

  1. Log in to comment