simfactory's hard-coded rsync options override a mdb entry's rsyncopts

Create issue
Issue #2053 closed
Roland Haas created an issue

Right now, in line 165 of simfactory/lib/sim-sync.py

   cmd = "%s --rsh=%s --rsync-path=%s %s %s %s" % (rsynccmd, simlib.QuoteSafe(sshcmd), simlib.QuoteSafe(machineEntry.rsynccmd), rsyncopts, machineEntry.rsyncopts, arguments)
    cmd = "%s %s" % (cmd, " ".join(rsyncoptions))

the hard-coded set of options in rsycnoptions

    rsyncoptions = [
        '--checksum',
        '--compress',
        '--delete',
        '--hard-links',
        '--links',
        '--partial',
        '--perms',
        '--progress',
        '--recursive',
        '--sparse',
        '--stats',
        #'--times',
        '--verbose']

overwrites the options passed in via the mdb (machineEntry.rsyncopts) since it appears later on the commmand line.

This is (currently) an issue for minerva, whose file system does not support hard-links, since there is no way to pass in a --no-hard-links option for just minerva.

Typically we don't have hard-links in our code trees, though it is certainly not something that is expected to never happen (eg I do have some hard links).

Keyword:

Comments (4)

  1. Roland Haas reporter
    • removed comment

    Anyone? If not I will apply this sometime during the week of Dec. 18th.

  2. Log in to comment