Hydro_RNSID should not inherit from GRHydro

Create issue
Issue #2128 closed
Zach Etienne created an issue

Hydro_RNSID will not compile without GRHydro, as apparently it inherits some variable(s) from GRHydro. Being a hydro initial data thorn, it should only depend on HydroBase & ADMBase.

Keyword: Hydro_RNSID

Comments (10)

  1. Roland Haas

    I have updated the pull request so that it again applies cleanly (and removed the GRHydro data from the testsuites). The pull request is ready to be reviewed.

  2. Roland Haas
    • edited description
    • changed status to on hold

    Wait for a couple of days for the dust of ET_2019_03 to settle, then apply since @zach_etienne says "please apply" in the pull request.

  3. Roland Haas

    I updated the pull request as follows:

    • removed all output for it>0 which is no longer generated once GRhydro is removed
    • removed out_info comments from output
    • removed ADMConstraints output which relies on Tmunu which relies on GRHydro
    • change RNSID atmo settings to match what GRhydro used

    with these changes (none of which changes "actual" data) the tests pass.

  4. Log in to comment