Fixed bug in calculation of conserved S vector in MHD Prim2Con

Create issue
Issue #2155 closed
Hannah Klion created an issue

Comments (5)

  1. anonymous
    • marked as
    • removed comment

    This bug produces incorrect physics since it computes the current densities incorrectly for MHD simulations using GRHydro using the C++ code.

  2. Roland Haas
    • removed comment

    The F90 code uses:

      dsx = sdet * ((drho*(1+deps)+dpress+b2)*w*w * vlowx - &
           ab0*blowx)
    

    and the papers (https://arxiv.org/abs/1304.5544 eq. 11) give:

    S_j = sqrt(detg) (ρh W v_j − α b_0 b_j)
    

    I have accepted the pull request and backported into the release code.

    We should send out an announcement since this affected science runs using default Einstein Toolkit parameters since commit fe5578d1d28d813cee37e35df69572ddc2f0ef71 "GRHydro: enable C++ code by default" from Mon Feb 23 00:01:14 2015 (and all code using the cxx flavor of GRHydro's MHD code since its inception).

  3. Log in to comment