make sim-ThornGuide fails

Create issue
Issue #2190 open
Roland Haas created an issue

One cannot build the ThornGuide using the current ET master (90d12c0b):

rhaas@ekohaes8:.../cactus/ET_vanilla$ make VERBOSE=yes sim-ThornGuide
echo ________________________________________________________________________
________________________________________________________________________
Creating ThornGuide for configuration sim
cd /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim; \
mkdir -p doc
rm -rf /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build
mkdir /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build
if test -r /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/ThornList ; then \
  cd /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build; \
  make -f /data/rhaas/postdoc/gr/cactus/ET_vanilla/doc/ThornGuide/Makefile THORNLIST=/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/ThornList MASTER_FILE=ThornGuide-sim DOCBUILDDIR=/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build; \
  if test -e "/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build/ThornGuide-sim.pdf"; then \
    mv "/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build/ThornGuide-sim.pdf" /data/rhaas/postdoc/gr/cactus/ET_vanilla/doc/ThornGuide-sim.pdf; \
    echo "  ThornGuide-sim.pdf created in doc directory."; \
    echo "  Done."; \
  fi \
        else \
          echo "  Error: /data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/ThornList not found."; \
fi
make[1]: Entering directory '/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build'
THORN_DEPENDENCIES=`/usr/bin/perl -s /data/rhaas/postdoc/gr/cactus/ET_vanilla/lib/sbin/ThornList.pl -arrangements_dir=/data/rhaas/postdoc/gr/cactus/ET_vanilla/arrangements -thornlist=/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/ThornList`
  Gathering documentation from thorn ccl files
    Processing....
       param.ccl....
/usr/bin/perl -s /data/rhaas/postdoc/gr/cactus/ET_vanilla/lib/sbin/ParamLatex.pl -cctk_home=/data/rhaas/postdoc/gr/cactus/ET_vanilla -directory=/data/rhaas/postdoc/gr/cactus/ET_vanilla/arrangements -thornlist=/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/ThornList -outdir=./ -section -grouping=bythorn -sort=scope > LOG_PARAMLATEX_MSGS 2>&1
make[1]: *** [/data/rhaas/postdoc/gr/cactus/ET_vanilla/doc/ThornGuide/Makefile:91: ThornGuide-sim.tex] Error 255
make[1]: Leaving directory '/data/rhaas/postdoc/gr/cactus/ET_vanilla/configs/sim/doc/build'

and the LOG file contains

Undefined subroutine &main::parse_ccl called at /data/rhaas/postdoc/gr/cactus/ET_vanilla/lib/sbin/parameter_parser.pl line 46.
   CTThorns

The line was introduced in git hash 618ef008 "Speedup branch implements caching of CCL files." about 1.25 years ago.

Keyword: None

Comments (4)

  1. Roland Haas reporter
    • removed comment

    [edited after noting that the svn repo is no longer used]

    This should probably be looked at before the release just in case the automated documentation generation that populates the tarball at https://build-test.barrywardell.net/job/EinsteinToolkit/lastSuccessfulBuild/artifact/doc/HTML.tar.gz will fail as well (though it seems to have been ok for a at least 1 release with the bug in the code it seems).

    Looking at this, this seem to need to run manually after each release so maybe this was just not done. Doing this at Docker creation seems a bit dangerous since it will pick up the tarball from the last successful run on master at the time the container is re-created rather than from the last release.

  2. Ian Hinder
    • removed comment

    It doesn't build the ThornGuide at all, it builds the ThornDoc, which is a different beast. The ThornGuide is a single file containing all the documentation, from what I remember, and it seems totally impractical. The ThornDoc produces one PDF (or HTML) file for each thorn, which is much easier to deal with, especially for the website version of the documentation.

    As a result, the ThornGuide is never automatically tested.

  3. Log in to comment