centos.cfg disables OpenMP

Create issue
Issue #2193 closed
Roland Haas created an issue

Git commit 2e827ac "Set MPI_DIR so that centos doesn't have to build MPI. Update the recommended yum packages so that libtldl is present." commented out all OpenMP settings in centos.cfg which given that the configure script says

determine OPENMP_MODE from the OPENMP option

if this option isn't set OPENMP_MODE will default to 'no'

this would mean that the code is not compiled with OpenMP making it impossible to test OpenMP parallelisation using this option list.

Keyword: None

Comments (13)

  1. Roland Haas reporter
    • removed comment

    Right now it still exists and we are frozen so removing it may be a bit abrupt (even though we are more lenient in simfactory acknowledging that it has to track moving targets), people seem to use it (see Maria's email to the mailing list).

  2. Roland Haas reporter
    • removed comment

    I agree. Will be nice to remove the many almost identical run sub and cfg files.

  3. Roland Haas reporter
    • removed comment

    So we leave this ticket open and remove after the release? We should then also set a milestone for the release after Wu.

  4. Roland Haas reporter
    • removed comment

    And add a deprecation warning to the release message (so no one can say they vanished unexpectedly).

  5. Steven R. Brandt
    • removed comment

    Probably we should have. However, cfgs in simfactory have always lived by a looser standard than the rest of Cactus.

  6. Roland Haas reporter
    • removed comment

    For updates sure, for going away, not so much. We can still remove them but really have to tell people in the release announcement how to switch over to generic.XXX then. At least it is a build-time failure and not a run-time failure.

    I think we should a milestone for the next release to this ticket so that we do not forget about it. The release ought to be one of 2019_02 or 2019_04 or 2019_05 (depending on "same as last year" or "this release plus 6 months" or "time of this release plus 6 months" :-) ).

  7. Log in to comment