- changed status to open
- removed comment
Multipole: Added code to test mode orthonormality
Issue #2210
resolved
Pull request is here: https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/3/multipole-added-code-to-test-mode/diff
This pull request was create by Eloisa but no ticket was created.
Keyword: Multipole
Comments (7)
-
-
Apparently I had started to add comments and review on 2018-11-08.
-
- edited description
-
assigned issue to
-
I updated the test proposed (since for eg trapezoidal rule, the 0,0 mode was not integration to 1+/01e-6 but only to 0.996 or so), and added a test for the midpoint rule as well.
Updated pull request is here:
-
Please review
-
Unless objected I will push this change after 2019-12-16
-
- changed status to resolved
Applied as git hash a9aaf204 "Multipole: add test for midpoint rule" of einsteinanalysis
- Log in to comment