- edited description
use bash_utils during ExternalLibraries detection phase
A while ago (in 2015) we were re-vamping the ExternalLibraries search mechanism. While multiple methods were proposed (using a package manager, custom code in bash, perl) the only one that saw much progress if Frank Loeffler's bash_utils.sh
code.
Right now many ExternalLibraries fail to detect themselves on "typical" Ubuntu based laptops because they do not handle Debian's multi-arch directory structure, giving the impression as if they were designed to always compile themselves (which was never the intent).
These pull requests make (some more of) ExternalLibraries use bash_utils.sh
to have a more uniform and more functional interface to specifying their location throughout the toolkit:
- https://github.com/EinsteinToolkit/ExternalLibraries-libjpeg/pull/1
- https://github.com/EinsteinToolkit/ExternalLibraries-LAPACK/pull/1
This is a bit of a stepping stone as I would like to push bash_utils.sh
itself towards a more well defined, and -- I think -- less surprising behaviour as outlined in: https://bitbucket.org/cactuscode/cactus/commits/db12237d823afc4e70f9bb8540bf7c03b2cc8f2e and a sample of how to use it is in https://github.com/EinsteinToolkit/ExternalLibraries-HDF5/tree/rhaas/findlib2 .
Note that this is a bugfix as the current detection mechanism fails to find an installed copy of the library.
Note about the pull requests: on github you first enter all your code comments then click on "publish" or similar. If you do not then you are the only person seeing the comments. So it is a multi-step process. On the plus side this means that there is not one email per source code line comment.
Comments (6)
-
reporter -
reporter - changed status to open
-
reporter - edited description
-
reporter Please review.
-
reporter Unless objected I will apply this after 2020-06-01.
-
reporter - changed status to resolved
Applied as git hash 4e216f4 "LAPACK: use bash_utils.sh to search for library" of ExternalLibraries-LAPACK
Applied as git hash 36262f2 "libjpeg: use bash_utils.sh to find library" of ExternalLibraries-libjpeg
Applied as git hash 22ffa3c "BLAS: use bash_utils.sh to search for library" of ExternalLibraries-BLAS
- Log in to comment