incorrect use of "opcodes" for "operation_codes" param table entry in AEILocalInterp users
Some thorns using AEILocalInterp incorrectly name the table of operation codes (plain interpolation, derivative, etc.) "opcodes" instead of the correct "operation_codes". Apparently an old api proposals (2.2) did indeed use "opcodes" and the affected thorns are probably descendants of a code using this early API.
The affected thorns are:
- Outflow (probably the one disseminating the incorrect usage, and having picked it up from earlier codes at PSU and GT) maintained by @rhaas80
- particle_tracerET maintained by @zach_etienne
- plus a number of non-public Zelmani thorns (since they descend from Outflow)
None of the thorns actually produces incorrect results since they all set the operation to be 0 (plain interpolation) which is the default.
In all cases the fix is to change "opcodes" to "operation_codes" in the name of the table entry. Changing the name of the variables used to hold the operation codes is optional.
Kindly pointed out by @shawngr2 who ran into this when actually having to compute derivatives.
Comments (7)
-
reporter -
reporter -
assigned issue to
@zach_etienne if you have time please review the pull request, apply and close my branch. The change is literally a
s/opcodes/operation_codes/g
. -
assigned issue to
-
reporter - changed status to open
Ready for review.
-
reporter @Zach Etienne Unless objected I will push after 2019-11-26.
-
@Roland Haas No objections!
-
reporter - changed status to resolved
His had already been applied as git hash c3e4c27 "Merged in rhaas/opcodes (pull request #2) particle_tracerET: use correct name "operation_codes" for interpolation table" of wvuthorns_diagnostics on 2019-04-28.
-
reporter - changed status to closed
- Log in to comment
A pull request for particle_tracerET is here: https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/pull-requests/2/particle_traceret-use-correct-name/diff
Fixed in Outflow in git hash 5afbb8d "Outflow: use correct name "operation_codes" for interpolation table" of einsteinanalysis