CarpetIOHDF5 out3d_vars recomputes active region each time instead of using stored copy
Issue #2270
closed
out3d_vars
lets one disable output of buffer regions and has to use the "active" region for this. Right now it recomputes the active region for each variable each time output is requested. This can be slow for large MPI rank counts. It is not necessary to recompute it however as the required information is stored as part of Carpet's level_boxes
data structure.
For large rank counts (~10k or so) this can take many minutes to recompute if many variables are output.
Comments (6)
-
reporter -
reporter - changed status to open
Please review.
-
Looks good to me.
-
reporter Excellent. Please click on the “Approve” button in the upper right corner of the pull request. That makes it official.
-
reporter - changed status to resolved
-
reporter - changed status to closed
- Log in to comment
Pull request is https://bitbucket.org/eschnett/carpet/pull-requests/28/carpetiohdf5-do-not-recompute-allactive/diff