einsteintoolkit / tickets / issues / #2301 - clean up code in GetComponents — Bitbucket

Issue #2301 resolved

Roland Haas created an issue 2019-11-12

GetComponents is not robust in its handling of branch and tag names and uses regular expressions with RHS being variables when really an equality is needed.

Pull request is here: https://github.com/gridaphobe/CRL/pull/8/files

Comments (3)

Roland Haas reporter
- changed status to open
Please review.
- 2019-11-12T17:06:35+00:00
Roland Haas reporter
Unless objected I will push this change after 2019-12-16
- 2019-12-03T01:39:48+00:00
Roland Haas reporter
- changed status to resolved
Applied as git hash d2e2554 "GetComponents: support whitespace in directory paths" of CRL
- 2019-12-18T14:43:00+00:00
Log in to comment

Assignee: –

Type: bug

Priority: minor

Status: resolved

Component: GetComponents

Milestone: –

Version: –

Votes: 0

Watchers: 1

Jira Software: the preferred issue tracker for Bitbucket. Join the team!