sort Perl hash keys to make generated code reproducable

Create issue
Issue #2318 resolved
Roland Haas created an issue

The order of some of the Cactus generated code depends on traversal order of perl hashes, eg the code to set up aliased functions. Perl, as part of its hardening against attacks, explicitly randomizes this order for each perl invocation. Thus, while there is no functional difference in the generated code, the generated files can change which can lead to unnecessary recompiles and also make it harder to run diff on the auto-generated source files.

Pull request https://bitbucket.org/cactuscode/cactus/pull-requests/80/rhaas-sortkeys/diff sorts all hash keys before they are iterated over.

Comments (3)

  1. Log in to comment