stop --follow'ing output when simulation ends
Currently sim show-output --follow
must be manually aborted when the simulation ends. This is inconvenient (at least) for the tutorial server notebook https://nbviewer.jupyter.org/github/nds-org/jupyter-et/blob/master/CactusTutorial.ipynb where the TOV evolution uses submit
(to show how this would be done on a real cluster) then show-output --follow
(to show what is going on) and requires users to press the “interrupt” button to continue in the notebook.
Pull request:
adds code to simfactory’s show-output
routine to kill -TERM
the tail
process running to show output when the simulation is detected to have ended (polled every 60 seconds).
Comments (4)
-
reporter -
reporter - changed status to open
-
reporter Unless objected (or even just the discussion picking up again) on https://bitbucket.org/simfactory/simfactory2/pull-requests/39/end-following-output-when-simulation-ends/diff I will commit this after 2020-02-29.
-
reporter - changed status to resolved
Applied as git hash 9db0eac "simlib: correct log entry for ExecuteReplaceCommand" of simfactory2
- Log in to comment
Please review.