build system does not check type of shared parameters
Issue #2342
resolved
This param.ccl file is accepted by Cactus:
SHARES: Cactus
USES KEYWORD cctk_final_time
in the C code the parameter type is correct (configs/th/bindings/include/ParFail/CParameters.h):
#define DECLARE_CCTK_PARAMETERS \
DECLARE_GLOBAL_PARAMETER_STRUCT_PARAMS \
CCTK_DECLARE_INIT (CCTK_REAL const, cctk_final_time, CCTK_PARAMETER__Cactus__cctk_final_time); \
This seems to be a failure in repos/flesh/lib/sbin/ImpParamConsistency.pl
Comments (4)
-
reporter -
reporter - changed status to open
Please review.
-
reporter Unless objected I will apply this after 2020-06-01.
-
reporter - changed status to resolved
- Log in to comment
This pull request:
https://bitbucket.org/cactuscode/cactus/pull-requests/89/rhaas-param-types-consistency/diff?w=1
adds code to check that parameter have consistent type. I have verified that types
CCTK_REAL
andREAL
are considered identical (at least when parsing with piraha, I assume piraha just strips a possibleCCTK_
prefix while parsing).