rdwr.pl does not accept multiple fully qualified variables names in a WRITES list
Issue #2357
resolved
Currently (6042cc3 "Merged in presync (pull request #1)" of einsteinbase) ADMBase’s schedule.ccl
contains schedule blocks like this:
SCHEDULE ADMBase_CartesianMinkowski in ADMBase_InitialData
{
LANG: C
WRITES: ADMBase::curv(Everywhere)
WRITES: ADMBase::metric(Everywhere)
WRITES: ADMBase::gxx_p(Everywhere), gxy_p, gxz_p, gyy_p, gyz_p, gzz_p
WRITES: ADMBase::gxx_p_p(Everywhere), gxy_p_p, gxz_p_p, gyy_p_p, gyz_p_p, gzz_p_p
WRITES: ADMBase::kxx_p(Everywhere), kxy_p, kxz_p, kyy_p, kyz_p, kzz_p
WRITES: ADMBase::kxx_p_p(Everywhere), kxy_p_p, kxz_p_p, kyy_p_p, kyz_p_p, kzz_p_p
WRITES: ADMBase::alp(Everywhere)
WRITES: ADMBase::shift(Everywhere)
WRITES: ADMBase::dtalp(Everywhere)
WRITES: ADMBase::dtshift(Everywhere)
WRITES: ADMBase::shift_state(Everywhere) #scalar
WRITES: ADMBase::dtlapse_state(Everywhere) #scalar WRITES: ADMBase::dtshift_state(Everywhere) #scalar
} "Set the metric and extrinsic curvature to cartesian minkowski values"
which look odd since eg only gxx_p
is fully qualified and has an Everywhere
attached to it. However changing the line like so
diff --git a/ADMBase/schedule.ccl b/ADMBase/schedule.ccl
index d6bab49..fe58b54 100644
--- a/ADMBase/schedule.ccl
+++ b/ADMBase/schedule.ccl
@@ -108,7 +108,7 @@ if (CCTK_Equals(initial_data, "Cartesian Minkowski"))
LANG: C
WRITES: ADMBase::curv(Everywhere)
WRITES: ADMBase::metric(Everywhere)
- WRITES: ADMBase::gxx_p(Everywhere), gxy_p, gxz_p, gyy_p, gyz_p, gzz_p
+ WRITES: ADMBase::gxx_p(Everywhere), ADMBase::gxy_p(Everywhere), gxz_p, gyy_p, gyz_p, gzz_p
WRITES: ADMBase::gxx_p_p(Everywhere), gxy_p_p, gxz_p_p, gyy_p_p, gyz_p_p, gzz_p_p
WRITES: ADMBase::kxx_p(Everywhere), kxy_p, kxz_p, kyy_p, kyz_p, kzz_p
WRITES: ADMBase::kxx_p_p(Everywhere), kxy_p_p, kxz_p_p, kyy_p_p, kyz_p_p, kzz_p_p
results in
ADMBase
Parse Error at /home/rhaas/postdoc/gr/cactus/ET_trunk/repos/flesh/lib/sbin/CSTUtils.pl line 966.
main::parse_ccl(Grammar=HASH(0x558ad5947be0), "sched", "/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/EinsteinB"..., "/home/rhaas/postdoc/gr/cactus/ET_trunk/repos/flesh/lib/sbin/."...) called at /home/rhaas/postdoc/gr/cactus/ET_trunk/repos/flesh/lib/sbin/ScheduleParser.pl line 95
main::create_schedule_database("ADMDerivatives", "/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/Llama/ADM"..., "EHFinder", "/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/EinsteinA"..., "WaveBinarySource", "/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/CactusWav"..., "HydroBase", "/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/EinsteinB"..., ...) called at /home/rhaas/postdoc/gr/cactus/ET_trunk/lib/sbin/CST line 168
CST ERROR IN FILE '/home/rhaas/postdoc/gr/cactus/ET_trunk/arrangements/EinsteinBase/ADMBase/schedule.ccl' make[1]: *** No rule to make target '/home/rhaas/postdoc/gr/cactus/ET_trunk/configs/sim/config-data/make.thornlist', needed by 'build'. Stop.
which seems wrong both in failing to be acceptable and in not producing a helpful error message.
Comments (3)
-
reporter -
No, I have been working on your other issues.
-
reporter - changed status to resolved
- Log in to comment
Any progress on this?