Cactus::psync_error = yes without Cactus::use_psync = yes makes all GF unaccessible

[Roland Haas]

Setting only Cactus::psync_error has the effect of making CCTK_HasAccess to return false for any real valued grid function b/c the current_function string in PreSync.h is never set.

It seems best if setting psync_erro also setting use_psync should not be allowed.

[Roland Haas]

As of git hash 58166448 "Carpet: do not use function name only to identify reads / writes" of carpet this no longer happens though the combination Cactus::psync_error=yes and Cactus::use_psync=no likely still has odd behaviour.

[Roland Haas]

Pontially this could be solved by collapsin use_psync, psync_error and psync_only into a single KEYWORD parameter with like so:

KEYWORD presync_level "how strongly to check data access"
{
  "no"    :: "disable all runtime checks"
  "check" :: "check allowed access and data correctness at runtime"
  "sync"  :: "automatically synchronize when needed"
  "only"  :: "disallow old-style boundary conditions and explicit synchronization"
} "no"

where “check” would be something like psync_error=yes and use_psync=no (so one needs to check that this actually works), while “sync” has them both on and “onyl” adds psync_only.

[Roland Haas]

there is now (git hash b7b66f02 "Cactus: introduce single presync_mode parameter to code" of cactus) a single keyword parameter presync_mode which avoids this issue.