Cactus build output is very verbose

Create issue
Issue #2408 resolved
Erik Schnetter created an issue

Cactus build output became very verbose with newer version of GNU make.

Comments (8)

  1. Erik Schnetter reporter

    This patch

    $ git diff Makefile 
    diff --git a/Makefile b/Makefile
    index d0ddff55..0037a60d 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -49,6 +49,7 @@ endif
     # Make quietly unless told not to
     ifneq ($(shell echo $(strip $(VERBOSE)) | tr '[:upper:]' '[:lower:]'),yes)
    +MAKEFLAGS += --silent
     # Stuff for parallel makes

    corrects the problem.

  2. Erik Schnetter reporter

    I see this problem with

    $ make --version
    GNU Make 4.3
    Built for x86_64-apple-darwin19.2.0

  3. Roland Haas

    This is likely caused by this bugfix "[SV 54740] Ensure .SILE"T settings do not leak into sub-makes” mentioned in the release notes which is bug on savannah. Turns out we would have wanted the buggy behaviour. Erik’s fix restores the behaviour that we want (ie propagation to sub-makes) though it might be better to add “--silent” at the beginning since MAKEFLAGS usually looks this:

    s -j2 --jobserver-auth=3,4 -- FOO=bar

    in a sub-make from a .SILENT make with -j2 and FOO=bar passed on the command line.

  4. Log in to comment