work around type issues in varags reduce function calls in Fortran
The old reduction API has an interface that, in Fortran, takes varaible numbers of arguments in the CCTK_Reduce
function, which is not supportable in Fortran which does not have this concept. Similarly the CCTK_ReduceLocalScalar
subroutines take a Fortran array as argument which triggers errors in some Fortran compilers when called with differently typed scalars.
This affects the TestReduction thorn as well as EHFinder.
These pull requests address the type issue:
- https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/13/ehfinder-explicitly-convert-void-pointers
- https://bitbucket.org/cactuscode/cactustest/pull-requests/3/testreduce-work-around-f77-compilers
Comments (7)
-
reporter -
reporter Unless objected I will apply this commit after 2020-07-15
-
reporter EHFinder change approved by @Peter Diener .
Applied as git hash 3df424fa "EHFinder: explicitly convert void* pointers to addresses" of einsteinanalysis
Applied as git hash 02b4a50 "TestReduce: work around F77 compilers checking subroutine argument lists" of cactustest
Will backport.
-
reporter - changed status to open
-
reporter Backported to ET_2020_05 as git hash 57490aa5 "EHFinder: explicitly convert void* pointers to addresses" of einsteinanalysis
-
reporter Backported to ET_2020_05 as git hash 8c6fb23 "TestReduce: work around F77 compilers checking subroutine argument lists" of cactustest
-
reporter - changed status to resolved
- Log in to comment
Please review.