MakeThornList issues

[Steven R. Brandt]

The option -m foo.th does not work (nor its variant -m=foo.th), but --master=foo.th does work. The usage message says the code was written by Ian Kelly. One of the default locations checked for the MasterThornList should be ./repos/manifest/einsteintoolkit.th, and multiple par files (or a directory containing par files) should probably be accepted.

[Roland Haas]

The POD lists authors as:

AUTHOR:

        Roland Haas <rhaas\@illinois.edu>
        Ian Kelley, <ikelley\@aei.mpg.de>
        March 20, 2020

which is correct. The script does use some code of Ian’s older version (admittedly mostly in the POD but still). So I would rather keep Ian listed as an author given that the script is base on his.

It seems as if the script does not accept any short options (even -v instead of --verbose). Seems like a failure to use Getopt::Long correctly to me.

[Roland Haas]

Correction: I had added my name to the author-list in an unpushed change only.

[Roland Haas]

Should all be fixed in git hash d9f98ca "MakeThornList: support short options using single dash" of utilities.

Thank you bringing this up.

[Roland Haas]

@Steven R. Brandt does this fix the issue for you?

[Steven R. Brandt]

Much better. I would still like to see it look in repos/manifest/einsteintoolkit.th for the master thorn list, and I’d still like to be able to specify multiple par files instead of just one.

[Roland Haas]

I cannot really make the script default to repos/manifest/einsteintoolkit.th since the script is in Cactus and not the ET. There are already defaults for the master thornlist (that I am inheriting from Ian’s implementation):

If this option is not
used, and the environment variable $CACTUSRC has been set, the
file $CACTUSRC/.cactus/MasterThornList will be used, otherwise the
file $HOME/.cactus/MasterThornList will be used.

and in fact also “ThornList” in that location (again inherited from Ian’s code).

To clarify: when passing multiple parfiles you would like to create a thornlist that can run any of those parfiles? Note that this can cause conflicts since some thorns cannot be compiled into the same executable (due to conflicting symbols), so making this work with a guarantee of no error messages when building is not quite a simple as just concatenating the parfiles when reading them. To trigger this one also needs to supply a master thorn list with both conflicting thorns listed (which ours is not because it can be compiled).

Relaxing this restriction then yes, supporting multiple parfiles is easy. I’ll post a pull request.

‌

[Roland Haas]

https://bitbucket.org/cactuscode/utilities/pull-requests/2/makethornlist-support-multiple-parameter

[Roland Haas]

Please review.

[Roland Haas]

Approved by @Steven R. Brandt

Applied as git hash 362c8b2 "MakeThornList: remove duplicate thorns from multiple parfiles" of utilities