use Perl strict and warnings in CST

Create issue
Issue #2456 resolved
Roland Haas created an issue

Cactus' build system driver (CST) is written in Perl but does not use strict or warnings meaning that variables do not have to be explicitly declared and many issues (such as using == instead of eq) are silently handled in unexpected ways.

This has led to a number of bugs being introduced in the past due to misspelled variables etc.

Comments (15)

  1. Roland Haas reporter

    Should be fixed in git hash 4e95b829 "Cactus: be more careful with undef vs. false in CST" of cactus.

    Was caused by the fact that the string “0”is false in Perl.

  2. Roland Haas reporter
    • changed status to open

    Using my $piraha_cache_dir = "..." in CST hides this variable from other packages (even when they use $main::pirarha_cache_dir it seems) and disables Piraha's caching of parsed files. Should be our $piraha_cache_dir.

  3. Log in to comment