use Perl strict and warnings in CST
Cactus' build system driver (CST) is written in Perl but does not use strict
or warnings
meaning that variables do not have to be explicitly declared and many issues (such as using ==
instead of eq
) are silently handled in unexpected ways.
This has led to a number of bugs being introduced in the past due to misspelled variables etc.
Comments (15)
-
reporter -
reporter Please review.
-
reporter - changed status to open
-
reporter Unless objected I will apply this after 2020-09-28.
-
reporter Approved by @Steven R. Brandt .
-
reporter -
reporter - changed status to resolved
Thank you.
-
reporter - changed status to open
This causes test failures in the TestArrays test.
-
reporter -
reporter - changed status to resolved
-
reporter - changed status to open
Using
my $piraha_cache_dir = "..."
in CST hides this variable from other packages (even when they use$main::pirarha_cache_dir
it seems) and disables Piraha's caching of parsed files. Should beour $piraha_cache_dir
. -
reporter Old versions of Perl report warnings about features (that we do not use) being deprecated. See
#2466 -
reporter Both fixed in branch rhaas/pirahacachehidden though it has not yet been fully tested (some of the occurances are in
RunTestUtils.pl
which is only run during a testsuite. -
reporter -
reporter - changed status to resolved
- Log in to comment
Pull request:
https://bitbucket.org/cactuscode/cactus/pull-requests/108/make-all-of-the-cst-perl-code-run-with
makes CST itself and all Perl files it requires use
strict
andwarnings
and lets one compile without encountering any warnings or errors.It also restores display of
SHARED
implementations that has been broken since it was attempted to be introduced in 2004 in 7f946a3d "Output shared implementations" of cactus.