use Perl strict and warnings in CST

[Roland Haas]

Cactus' build system driver (CST) is written in Perl but does not use strict or warnings meaning that variables do not have to be explicitly declared and many issues (such as using == instead of eq) are silently handled in unexpected ways.

This has led to a number of bugs being introduced in the past due to misspelled variables etc.

[Roland Haas]

Pull request:

https://bitbucket.org/cactuscode/cactus/pull-requests/108/make-all-of-the-cst-perl-code-run-with

makes CST itself and all Perl files it requires use strict and warnings and lets one compile without encountering any warnings or errors.

It also restores display of SHARED implementations that has been broken since it was attempted to be introduced in 2004 in 7f946a3d "Output shared implementations" of cactus.

[Roland Haas]

Please review.

[Roland Haas]

Unless objected I will apply this after 2020-09-28.

[Roland Haas]

Approved by @Steven R. Brandt .

[Roland Haas]

Applied as git hash 6397d383 "Cactus: make all of the CST perl code run with strict and warnings" of cactus

[Roland Haas]

Thank you.

[Roland Haas]

This causes test failures in the TestArrays test.

[Roland Haas]

Should be fixed in git hash 4e95b829 "Cactus: be more careful with undef vs. false in CST" of cactus.

Was caused by the fact that the string “0”is false in Perl.

[Roland Haas]

Using my $piraha_cache_dir = "..." in CST hides this variable from other packages (even when they use $main::pirarha_cache_dir it seems) and disables Piraha's caching of parsed files. Should be our $piraha_cache_dir.

[Roland Haas]

Old versions of Perl report warnings about features (that we do not use) being deprecated. See #2466

[Roland Haas]

Both fixed in branch rhaas/pirahacachehidden though it has not yet been fully tested (some of the occurances are in RunTestUtils.pl which is only run during a testsuite.

[Roland Haas]

Applied as git hash a763348f "Cactus: avoid spurious warnings from Perl 5.10 about split" of cactus