BLAS and LAPACK ExternalLibraries ignore BLAS_DIR and LAPACK_DIR

Create issue
Issue #2476 on hold
Roland Haas created an issue

Git hash 22ffa3c "BLAS: use bash_utils.sh to search for library" of ExternalLibraries-BLAS and git hash 4e216f4 "LAPACK: use bash_utils.sh to search for library" of ExternalLibraries-LAPACK changed BLAS and LAPACK to use bash_utils’s find_lib to look for library files.

However in this process multiple bugs were introduced (by me). One was reported by @Samuel Tootle in #2464, @Steven R. Brandt just found another one due to using an incorrect variable name in the find_lib call, which went unnoticed on systems where LAPACK / BLAS are found in “standard” locations via pkg-config, which is the majority of systems where it is used it seems.

Fixed in git hash 6e55384 "BLAS: fix typo making BLAS_DIR being ignored" of ExternalLibraries-BLAS and git hash 6284631 "LAPACK: fix typo causing LAPACK_DIR to be ignored" of ExternalLibraries-LAPACK but needs testing.

Comments (5)

  1. Roland Haas reporter

    Most likely I will revert git hash 22ffa3c "BLAS: use bash_utils.sh to search for library" of ExternalLibraries-BLAS and git hash 4e216f4 "LAPACK: use bash_utils.sh to search for library" of ExternalLibraries-LAPACK since BLAS and LAPACK handle BLAS_DIR and LAPACK_DIR in a way not supported by bash_utils. After the 2020_11 release I will propose to change how BLAS_DIR and LAPACK_DIR are handled along with proposing a better defined behaviour for ExternalLibraries.

  2. Log in to comment