Issue #2503 open
I found the following small problems in
- The thorn defines
initial_shift, …, but it ignores all of them. If you activate the thorn, it will always set the initial data.
- The thorn checks if
Kis set so that
rho_maxis 1 and provides suggestions to fix the problem depending on your choice of Gamma. These suggestions are hard-coded even if they depend on the parameters used for the disk.
- The file
FMdisk_GRHD_rho_initial.his never used.
- The parameter
A_bis defined but never used.
Having used this thorn for a little bit, I now have the following considerations:
- I think that the perturbation should be added optionally and not by default
- I found using the thorn rather clunky: every time I have to change the disk parameters, I need to run an empty run to find what value of K should be used. Since K is uniquely determined by the thorn, It would be nice if
FishboneMoncriefIDoverrode the values set for
GRHydroin the parameter file (which I have to do anyways ‘by hand’).
- The parameter for the spin is called
a, which is practically impossible to grep in the source code.
- The documentation is only offered as Jupyter notebooks, which is more impractical to consult quickly on remote clusters and more difficult to grep in