The trac mailing list could have more useful content

[Gabriele Bozzola]

I am subscribed to the trac mailing list to follow reported bugs. When I get an email, the only useful information I can extract is the title of the ticket. For example,

http://lists.einsteintoolkit.org/pipermail/trac/2021-April/015293.html

If I click on the link, I end up in a non-render HTML page which is very difficult to parse visually. So, if I want to understand what is going on, I have to visit this website, find the relevant ticket, and find the new post. I think that the mailing list would be much more useful if it actually included the new comments, or if it provided a direct link to the post.

‌

[Roland Haas]

The mailing list emails are HTML (only) emails, which so far seem to have been ok with the usual email clients (which would prefer the HTML part even if there was a plaintext alternative). Which email client are you using?

The archive was supposed to render HTML parts into plain text as far as I can tell from the mailing list settings. I will try and see if I can find out what is going wrong or (more likely) I may be misunderstanding the mailman options.

[Gabriele Bozzola]

I can reproduce this problem with GMail, but maybe I should clarify that I get these emails with the option digest (looking at pipermail I assumed that this detail was not important). This is what I see as subject of the email:

‌

If I click on the link, I end up in a HTML page that is not rendered.

[Roland Haas]

I suspect that the digest is to blame.

The HTML pages in the link are set up by mailman to show the raw HTML so that no one can send a HTML attachment the mailing list with say malicious javascript code which then gets executed when the HTML page is shown in your browser. While one seems to be able to disable this, this seems to be a mailman wide setting and that seems to be risky.

[Gabriele Bozzola]

Is it possible to include the link to the ticket somehow?

[Roland Haas]

Well its in the HTML content… which is of no use to use since you cannot see the HTML in the digest. Currently the HTML looks like this when properly rendered: https://ekohaes8.ncsa.illinois.edu/~rhaas/2523.html

The “proper” solution is to generate a “multipart/alternative” email which has both plaintext (for archiving and digest) and HTML (everyone else) content. Due to the way Bitbucket works (and not wanting to enter into the whole mess of creating content preserving plaintext from HTML) the plaintext will be the markdown source which may or may not look nice.

[Roland Haas]

Should be fixed as of git hash 43c84d7 "hooks: add comment on testing" of www

[Gabriele Bozzola]

I still see the same messages:

‌

[Roland Haas]

Old messages will not have their archived content updated, similarly the digest may take a day or so to show anything. The first email that will look ok is likely going to be the one where you say “I still see the same messages”.

[Gabriele Bozzola]

Perfect! Thanks!

‌

[Gabriele Bozzola]

I think that there’s still some minor issue. The email I got today had the following:

As you can see, the message is not the correct one (but the URL is).

[Roland Haas]

I think the email is correct. I accidentally added that comment to the wrong ticket and then deleted the comment. So that comment would not show up in the web-view of the ticket right now but will show up in emails (which are generated the moment one modifies a ticket). We may have to add a “removed comment” case, though I am not sure if Bitbucket lets on hook into that event.

[Gabriele Bozzola]

I see! I guess that the current behavior is acceptable, when the comments seems out of place, it is always possible to follow the link (which is what I did) and see exactly what is going on.

[Roland Haas]

Well in this case it was just me posting the comment in the wrong spot. Turns out there is no way to be notified about comments being removed. The callout for the comment creation was: https://bitbucket.org/!connect_apps/webhooks/connect/?repo_uuid={e08803fe-d62a-43de-ad42-8c27935f7dc8}&xdm_e=https%3A%2F%2Fbitbucket.org&xdm_c=channel-364af0e3-6b88-42d1-bee7-431d3f4bc7b4&user_uuid={c7772412-f976-415d-b26b-4d82d74f3f45}&crev=ecbee347f70a%2Fdist%2Fconnect%2Fv5&repo_path=einsteintoolkit%2Ftickets&jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJjb25uZWN0aW9uOjEwNDI4MCIsImlhdCI6MTYxOTcxMTYzNiwicXNoIjoiMDU1ZmJmNWU2ZmZhYjUzZGMxNGYxNjljYzNhMWU4YzIyMzg1NmEzNzhhYmE5YWJhY2Y1OTViOTc4MTYwY2U2MyIsImF1ZCI6ImNvbm5lY3Rpb246MTA0MjgwIiwiZXhwIjoxNjE5NzExOTM2fQ.O1-8Hnj6Rkgx43a6xvC7ho3lHTKCvmSLrv6wHXDUIyc#/b1beef0a-aab4-4384-be6e-c635fee232a7/requests/1279074c-9f7e-4a5e-bad8-5cf723d44cd8 but there is no delete callout in https://bitbucket.org/einsteintoolkit/tickets/admin/addon/admin/bitbucket-webhooks/bb-webhooks-repo-admin so deleted comments will remain “orphans” in the mailing list since their removal is not reported.