"ActiveThorns" not accepted in parameter file

[Erik Schnetter]

I see an error with a parameter file that used to work fine. The error is

‌

WARNING level 0 from host redshift.local process 0
  in thorn cactus, file qc0.par:1:
  -> ERROR IN PARAMETER FILE:Parse Error
Expected one of the following characters: ':', '(', '*', '/', '%', '+', '-', '<', '>', '&', '|', '!', '$', 'a', 'A'
# run.memory: 1.0e9
# run.time: 7200.0

ActiveThorns = "
             ^

The parameter file starts with

# run.me:
# run.cores: 40
# run.memory: 1.0e9
# run.time: 7200.0

ActiveThorns = "
ADMBase
CarpetX
Coordinates
ErrorEstimator
Formaline
IOUtil
ODESolvers
TimerReport
TmunuBase
TwoPunctures
Weyl
Z4c
"

I attach the full parameter file.

[Erik Schnetter]

I figured it out: The parameter file has two ActiveThorns declarations. The parser complains about the second one.

Line numbers would be useful…

[Erik Schnetter]

… and the reason the parameter file was duplicated was that I wrote IO::out_dir = $parfile in an *.rpar file.

‌

[Steven R. Brandt]

The thing that confused the parser was the empty assignment to out_dir. It was looking for the value of output_dir, and found ActiveThorns. Should we disallow empty RHS?

At the moment, I’m working to fix the line number issue.

IO::out_dir =

‌

[Roland Haas]

My take would be that to me:

IO::out_dir =

would be an error but that:

IO::out_dir = ""

is valid (so not the RHS is emtpy but the value). The tricky bit would seem to classify:

foo = 
bar = 12

as an error on foo, while allowing:

foo = 
bar
baz = 12

‌

[Steven R. Brandt]

https://bitbucket.org/cactuscode/cactus/pull-requests/124/fixing-2533

[Roland Haas]

Please apply.

[Roland Haas]

Applied as git hash 248d4f05 "Merged in fixing_2533 (pull request #124)" of cactus