utf-8 decode failure when using create-run

[Former user]

Lorenzo Ennoggi just encountered an issue with simfactory where it fails with an utf-8 decoding error due to an invalid utf-8 character in Cactus' output stream in simfactory/lib/simrestart.py line 1016:

out_txt = out_read.read()

then can probably be avoided by ensuring that we read and write "byte" objects (and use binary file IO) rather than "strings".

[Roland Haas]

Pull request is here: https://bitbucket.org/simfactory/simfactory2/pull-requests/59/rhaas-bytestreams

Tested with this invalid byte stream from stackoverflow:

echo "utf 8 test"
printf '\xc3\x28\n'
exit 0

in a RunScript file.

[Roland Haas]

Please review.

[Roland Haas]

Approved in https://bitbucket.org/simfactory/simfactory2/pull-requests/59/rhaas-bytestreams#comment-240331620

[Roland Haas]

Applied as git hash 7553af2 "simrestart: when piping data to log files, read and write raw bytes" of simfactory2