remove use of finite() function call superceded by isfinite in C99

[Roland Haas]

Apple removed the finite() function on their M1 version of macOS causing compiler failures. Affected thorns are:

• IllinoisGRMHD
• AHFinderDirect
• GRHydro
• GRHydro_InitData
• TGRTensor

‌

‌

[Roland Haas]

Pull requests

• https://bitbucket.org/zach_etienne/wvuthorns/pull-requests/7/illinoisgrmhd-use-std-isfinite-instead-of
• https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/18/ahfinderdirect-remove-use-of-finite
• https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/16/do-not-use-finite-but-isfinite
• https://bitbucket.org/einsteintoolkit/einsteinutils/pull-requests/3/tgrtensor-use-isfinite-rather-than-finite

‌

[Roland Haas]

Please review.

[Roland Haas]

Discovered by @helvi witek

[Zach Etienne]

Thanks Helvi and Roland! The IllinoisGRMHD PR has been approved and merged.

[Roland Haas]

Unless objected I will apply these after 2021-09-30.

[Roland Haas]

Applied as git hash 42c9579b "AHFinderDirect: remove use of finite()" of einsteinanalysis

Applied as git hash 480b915 "GRHydro_InitData: use C99 isfinite() rather than finite()" of einsteinevolve

Applied as git hash aabd1ed "SetMask_SphericalSurface: add ParamCheck routine" of einsteinutils