`CCTK_CENTERING_GF` is applied to grid scalars

Issue #2600 resolved
Erik Schnetter created an issue

It seems that Cactus applies the CCTK_CENTERING_GF macro not just to grid functions, but also to grid scalars. This fails at run time since CarpetX notices that the GF3D2 class doesn’t work for grid scalars.

Comments (9)

  1. Roland Haas

    @Steven R. Brandt any news on this? Or have you already addressed this in the code and the issue can be closed?

  2. Steven R. Brandt

    On looking at the code, I don’t see how this is possible. That condition is explicitly checked for.

  3. Steven R. Brandt

    I believe this issue was fixed here:

    commit f49477f6ddeeb0fcaa80486a37dc9fa2482385a4
    Author: Steven R. Brandt <steven@stevenrbrandt.com>
    Date:   Thu Jun 23 12:59:42 2022 +0000
        Merged in only_center_gfs (pull request #141)
        * Use only for GF
        * Only GF's get a cctk_ptr_ declaration and centering.
        Approved-by: Erik Schnetter

  4. Log in to comment