Add four more parameters for carpet

[Liwei Ji]

Hi all,

we have added four more parameters to carpet:

1. uniformly_split_interior_points_x
2. uniformly_split_interior_points_y
3. uniformly_split_interior_points_z
4. symmetrically_distribute_points_y

The first three parameters are used to distribute the grid points across processors uniformly according to interior points only.

The fourth parameter is used to distribute the (even number of) grid points across (even number of) processors with the first and second half being translational symmetric to each other in y-dir, when the grid points are not divisible by the number of processors in y-dir.

Attached please find the diff with the master branch. Thanks!

[Roland Haas]

Please create a pull request.

Why only add these 4 parameters and not parameter for all xyz and uniform / symmetric combinations?

[Liwei Ji]

Right. I will add 6 parameters and create a pull request then

[Roland Haas]

Pull request is here: https://bitbucket.org/eschnett/carpet/pull-requests/50/add-six-pars

[Roland Haas]

Please review.

[Liwei Ji]

Hi Roland, I’m not sure how to review. Could you help me with more details? Thanks

[Roland Haas]

There are some suggestions on the “How to review a patch” page of the wiki (somewhat hidden, since it is listed in the “maintainers” section of the front page only):

https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_Patch