Inclusion of AsterX in the Einstein Toolkit

[Jay Kalinani]

AsterX is a new GRMHD code based on the CarpetX infrastructure. It is currently under development, but is close to the stage where it can be used to simulate systems such as a single magnetized TOV star. Its source code availability in the ET checkout can also serve as a starting point for the ET community to write their own MHD codes or build upon it.

Since AsterX is based on CarpetX, its building requires inclusion of CarpetX in the ET.

The Wiki page with a TODO list is:

https://docs.einsteintoolkit.org/et-docs/AsterX

‌

[Samuel Cupp]

After discussion, the AsterX developers decided to delay the addition of AsterX into the Toolkit until the November 2023 release to align with the planned CarpetX full release.

[Samuel Cupp]

@Jay Kalinani Can I get a list of what thorns are being included in this proposal from the AsterX repo? Also, please @ anyone else that should be involved in this discussion.

[Jay Kalinani]

@Samuel Cupp Here are the list of thorns to be included from the AsterX repo (given that CarpetX is included as well):
- AsterX
- AsterSeeds
- Con2PrimFactory
- EOSX
- ReconX
- TOVSolver
Note that we still need reviewers for these thorns, and we are currently working on the first AsterX paper.

‌

[Samuel Cupp]

TOVSolver can’t be named TOVSolver, as that is already a thorn. It would either need to be e.g. TOVSolverX or somehow have its changed merged into the original thorn.

[Samuel Cupp]

Also, don’t forget that several thorns have unneeded dependencies (e.g. TOVSolver depending on AsterX) that should be removed.

[Jay Kalinani]

Points well noted! Will certainly incorporate the suggested changes.

[tootle]

I can offer being a reviewer if need be

[Samuel Cupp]

Hi @tootle . Thanks for offering to help. We asked Bruno’s group but haven’t heard back yet. If they do respond soon, I would see whether AsterX or SpaceTimeX is in more need of a second reviewer and ask you to help with that. If we don’t hear anything back, Jay and I would greatly appreciate you reviewing AsterX.

[Samuel Cupp]

@tootle Hey Samuel. Are you still willing to review AsterX? If so, I’ll send out an email with info (though you’ve gone through this process recently) to you and Jay.

[Samuel Cupp]

Also, @Jay Kalinani , if anyone else should be listed as contributors on the release please let me know and make sure to double-check those lists when they come out. There’s been some issues in the past regarding people not getting listed because the release managers weren’t informed that there were additional code authors. “Contributor” here generally means major contributors to the AsterX thorns, similar to paper authorship.

[tootle]

@Samuel Cupp No problem