make ADIOS2 compile on macOS

[Roland Haas]

macOS's malloc include file uses a variable named type_id which conflicts with the #define type_id used by ADIOS2

[Roland Haas]

Pull request is here: https://github.com/EinsteinToolkit/ExternalLibraries-ADIOS2/pull/6

[Roland Haas]

Please review.

[Roland Haas]

This is fixed in ADIOS 2.9.2 so will not need to be fixed in master anymore. 

This should be backported to the release though.
So there’s two options:

1. apply the patch here to the release version (2023_11) only
2. bump the release’s included tar file to 2.9.2 which fixes the issue but brings in other changes as well

In SGRID #2771 I applied the patch to the release even after master received a fix to the tar file (deeming the changes in the tar file to be more extensive than a minimal fix desired for the backport). By the same argument one would apply the patch here, but the patch here is less “nice” and changes files that I doubt are actually used on macOS (being in directories named “windows”).

Comments?

[Roland Haas]

Comments in the ET call on Feb 15th say to backport the tar file.

Done in git hash 4caaaaa "ADIOS2: update to 2.9.2" of ExternalLibraries-ADIOS2