GRHayLib fails to compile on testing server with ‘max_lorenz_factor’ undeclared

[Roland Haas]

On the CI testing server building the ET fails with:

-05T00:10:22.0014094Z Checking status of thorn GRHayLib
2024-03-05T00:10:22.1750005Z COMPILING GRHayL/GRHayLib/src/initialize_and_shutdown.c
2024-03-05T00:10:22.2282841Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c: In function ‘GRHayLib_initialize’:
2024-03-05T00:10:22.2286561Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c:165:7: error: ‘max_lorenz_factor’ undeclared (first use in this function); did you mean ‘max_Lorentz_factor’?
2024-03-05T00:10:22.2288608Z   165 |       max_lorenz_factor, Lorenz_damping_factor,
2024-03-05T00:10:22.2289476Z       |       ^~~~~~~~~~~~~~~~~
2024-03-05T00:10:22.2290397Z       |       max_Lorentz_factor
2024-03-05T00:10:22.2292076Z /home/runner/work/tests/tests/master/configs/sim/build/GRHayLib/initialize_and_shutdown.c:165:7: note: each undeclared identifier is reported only once for each function it appears in
2024-03-05T00:10:22.2324428Z make[3]: *** [/home/runner/work/tests/tests/master/configs/sim/config-data/make.config.rules:267: initialize_and_shutdown.c.o] Error 1
2024-03-05T00:10:22.2327122Z make[2]: *** [/home/runner/work/tests/tests/master/lib/make/make.thornlib:113: make.checked] Error 2
2024-03-05T00:10:22.2332236Z make[1]: *** [/home/runner/work/tests/tests/master/lib/make/make.configuration:179: /home/runner/work/tests/tests/master/configs/sim/lib/libthorn_GRHayLib.a] Error 2

See full log at https://github.com/EinsteinToolkit/tests/actions/runs/8148610359/job/22271765455#step:9:29381

This does not seem to happen on my workstation.

[Samuel Cupp]

@Roland Haas I pushed a fix that should resolve that. I don’t know what the CI schedule is on, but please let me know if it fails again.

[Roland Haas]

hmm, this has been fixed around
git hash ee70afd "Fixed Lorenz->Lorentz in parameter name" of GRHayL and git hash fbb3d00 "CI: fixed compilation error" of GRHayL or so, yes? Those claim be couple of days old, but maybe “commit” and “push” here are different. I’ll trigger a CI build.

[Roland Haas]

Test of trac header encoding, please ignore.