Noise generation in ADMBaseX is not reproducible and not easily controlled.
This moves noise generation to a separate thorn and makes and improves noise reproducibility by allowing users to use fixed noise engines with fixed noise seeds.
Noise generation in ADMBaseX is not reproducible and not easily controlled.
This moves noise generation to a separate thorn and makes and improves noise reproducibility by allowing users to use fixed noise engines with fixed noise seeds.
Please review
It might be good to model the interface of this thorn after that of the existing CactusNumerical/Noise thorn instead of making a new one up from scratch.
Roland to provide an example on how to set the variables using strings.
Roland to point to: https://www.einsteintoolkit.org/referencemanual/ReferenceManual.html#x1-293000C
In today’s ET call Lucas mentioned that that even when specifying the explicit random number generator different STL implementations are not required to produce the same sequence of numbers even when given the same seed.
There’s also (vertex) data that is double covered by the grid.
Pull request is here: https://github.com/EinsteinToolkit/CarpetX/pull/334