Multipole HDF5 file truncation with multiple variables

Create issue
Issue #302 closed
Ian Hinder created an issue

Previously a "first_time" variable was used to determine if truncation should happen. When decomposing multiple variables, this logic is incorrect. We now store the first_time information per output file.

I have tested the patch.

Keyword: Multipole

Comments (7)

  1. Erik Schnetter
    • removed comment

    The patch looks good.

    I would use set<...> instead of map<...,bool>. I would also move changing the map (set) into the then branch of the if statement.

  2. Ian Hinder reporter
    • removed comment

    I agree with you about the changes. However I don't have time right now to make and test them. Since the patch works, and the suggested changes are only aesthetic, I would like to apply the patch to fix the bug right now, and the aesthetic changes can be fixed later. We can leave the ticket open so that we don't forget. Do you agree?

  3. Log in to comment