Machine entry in defs.local.ini but not in mdb leads to bad error message

Create issue
Issue #305 resolved
Ian Hinder created an issue

If I have an entry for my local machine in defs.local.ini but I do not have an mdb file for it, I get the following error:

MacBook:llama ian$ sim2 sync datura Error: required key basedir in section macbook is missing

This does not tell me what the problem is. I would expect to get the same error as when the section is not present:

MacBook:llama ian$ sim2 sync damiana Unknown machine name macbook Info: Simfactory command: simfactory2/bin/../lib/sim.py "sync" "damiana" Info: Version 1230 The Simulation Factory: Manage Cactus simulations

Info: defs: /Users/ian/Cactus/llama/simfactory2/etc/defs.ini Info: defs.local: /Users/ian/Cactus/llama/simfactory2/etc/defs.local.ini Error: Unknown local machine macbook. Please use 'sim setup' to create a local machine entry from the generic template.

Keyword:

Comments (5)

  1. Roland Haas

    One downside of this change is that a misspelled entry in defs.local.ini will only trigger a warning now while before it would have aborted simfactory, eg a section

    [stammpede2]
    user = rhaas
    

    (with an extra “b”) will only trigger a warning about an incomplete machine “stammpede2” while before it would have aborted with “stammpede2” missing some keys.

  2. Roland Haas
    • changed status to open

    This needed to be amended (in a5f0e5c) to skip syntax checks until defs.local.ini exists. This happens to be what simfactory also did before, however this can lead to bad behaviour on clusters where one can submit a job without ever running sim init and thus never creating defs.local.ini and thus never setting user, email or account.

  3. Log in to comment